GuildWiki talk:Bot tasks/License reminder

Image license guide linky? --- -- (s)talkpage  16:28, 29 May 2008 (UTC)
 * Yes, I think give reminder for each image, otherwise unexperienced users will go back to license 1/5 that they uploaded and forget about the other 4, or something... When the bot posts on a talk page, have it check if a section already exists for previous reminders, and just add to it, instead of making a new section for each notice, which can get pretty ugly if someone uploaded a bunch of images and forgot to license them all.  Also, the licensing feature does not work correctly, still.  If you upload a BRAND NEW image, it works just fine, but if you upload a new version of an old image that did not have licensing before, then choosing the drop down licensing will not work, and the image will still be unlicensed.  Might want to address that issue somewhere, if you can.  I posted it on the staff board, but nothing happened. RoseOfKali [[Image:RoseOfKaliSIG.jpg]] 16:07, 31 May 2008 (UTC)


 * It sounds like a great idea to me -- I've come across a fair amount of untagged images recently. Go go go! :] [[Image:Maui_sig.png]] 19:23, 5 June 2008 (UTC)


 * This sounds like a great idea in my opinion. I often see users uploading images, that I end up tagging 10 seconds later anyways.  Typically these are just gw screenshots, but there are sometimes copy vio's that can be caught this way, and not stay in the system for months or even longer... just look at Special:Uncategorizedimages. As far as multiple posts for multiple image uploads, I'm rather impartial on this.  As Rose stated, multiple posts for multiple images would help users to not forget their other 4 uploads.  But at the same time, it would create alot of unnecessary text on the user page.  Which could be a good thing in itself, it would remind that user not to forget licensing tags ever again :P.  And typical users don't upload more than a couple images at a time anyway.  Template:Image copyright or Template:Unattributed image could easily be used on the user's talk page to inform them of their images copyright status, or does your bot have a different way of posting on the user's talk page?
 * How often should this run?
 * I think once a week is more than enough. -- [[Image:Isk8.png]]  I~sk8   (T/C) 19:36, 5 June 2008 (UTC)
 * The examples on User talk:RogueJedi show exactly what the message would look like (except i wouldnt include the username in the heading). It just gives a list of all images that the bot found since its last run that the user uploaded that were missing copyright status. &mdash;♥ Jedi ♥ Rogue ♥ 19:41, 5 June 2008 (UTC)
 * I would say a separate post for each image- easier to keep track of. And run it like 6 times a day. [[Image:Felix_Omni_Signature.png]] 20:57, 5 June 2008 (UTC)
 * Seriously? Separate posts would leave a lot of junk on talk pages of users that have alot of images. Also, 6 times a day? I'm manually triggering each run, not leaving it running 24/7 with a timer lol. &mdash;♥ Jedi ♥ Rogue ♥ 21:58, 5 June 2008 (UTC)
 * Well then, once a week is probably fine. I would still support multiple posts, though- the people who have lots of uncategorized images are the the ones that need the largest reminder. It's not punishment, it's just a friendly... TORMENT. >:D [[Image:Felix_Omni_Signature.png]] 22:38, 5 June 2008 (UTC)

possible issues
I don't know Java well, but I'll at least give some general comments. That's all I see for now. &mdash;Dr Ishmael 19:43, 5 June 2008 (UTC)
 * In function isNeedingLicense, you should include the lc versions for all of them, like you did for .  I know I've seen  at least a few times.
 * In function postReminders, shouldn't you be stripping the last two characters (", ") from String imgs before passing it to leaveMessage? Or am I just missing where that happens?
 * 1. Yes, I can add that. It will just make the if statement longer. (actually, I'll just .toLowerCase the whole thing before I check.) 2. I didn't bother stripping it at all. I suppose I could but its just one more string manipulation which IIRC aren't really desirable operations because it takes up extra memory. Meh, I'll add it anyway.&mdash;♥ Jedi ♥ Rogue ♥ 19:48, 5 June 2008 (UTC)
 * A different approach to listing the images: put them into a wiki-list. That way, each one could be formatted as   (assuming Java is like most languages in using \n for linefeed), and a trailing \n on the last img wouldn't need to be removed, but in fact would be necessary to separate it from the rest of the text. &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 20:19, 5 June 2008 (UTC)
 * I considering that but felt it might make things cluttered for a long list of files. Hopefully, however, there won't ever be lists of files that are too long as it would slow down the whole program. That would only come up if someone decided to run this from a very early start date (say if we wanted to leave messages on the user pages of all image uploaders since the dawn of time). However this made me realize that we could run into issues if someone were maliciously to change the last run date. My suggestion would be to put the last run date somewhere else on a protected page. (protect it so only registered users or only sysops? if sysop, the bot would need to be a sysop too because it needs to edit the page itself.). Thoughts? &mdash;♥ Jedi ♥ Rogue ♥ 20:27, 5 June 2008 (UTC)
 * Instead of depending on anything on the wiki, I would store the date in a config file on my computer. &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 21:11, 5 June 2008 (UTC)
 * I wanted it to be available so people could see when it was last run. But I could just post it there and get the last run date from my computer. Good idea. This is why we have others review before we start all you impatient people!!&mdash;♥ Jedi ♥ Rogue ♥ 21:55, 5 June 2008 (UTC)

The bot needs to have a twin that can remove the notices (or images from them) once the images comply or are deleted. --mendel 21:26, 5 June 2008 (UTC)
 * If I had manually posted something like that on a person's page, I wouldn't feel the need to remove the message after they did it. Why is this different? Additionally, that's alot of extra work, to go back and find the images, recheck them, and parse the person's talk page to make those edits. &mdash;♥ Jedi ♥ Rogue ♥ 21:55, 5 June 2008 (UTC)
 * I agree, that's way too much work. There used to be a bot that did a similar thing a long time ago, and some of its notices are still sitting around on talk pages.  The users can archive/remove the notice at their convenience, as long as they've complied with it.  &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 22:23, 5 June 2008 (UTC)

Just noticed one more bug - you're missing, unless you were specifically excluding that for some reason. Mendel's XHTML icons are licensed with that. &mdash;Dr Ishmael 22:29, 5 June 2008 (UTC)
 * Good catch. I may have initially left that out because I was considering adding an extra check for that one to make sure that it provided valid sources. However, I decided I was going to leave that out of the scope of this task for now. I'll re add it. Also, as you probably noticed and as I expected, it seems to work find for talk pages that didn't previously exist.&mdash;♥ Jedi ♥ Rogue ♥ 22:35, 5 June 2008 (UTC)

The Message
No, I'm not applying for a concession, nor do I want to rent out scooters. But anyway... I want a better message, and a better way to place it on the page. Mainly because it doesn't allow for checking or changing. --mendel 21:24, 5 June 2008 (UTC)
 * 1) The proposed message is Hello, <username. You are receiving this automated message because you recently uploaded files to GuildWiki. The following images appear to be missing licensing information: . Please see GuildWiki:Image license guide for more information. Thank you for your contributions. This is an automated message from . It lacks the following:
 * 2) Date of the run
 * 3) Person responsible for the run (though that'll be in history)
 * 4) Person(s) to contact, or link to a page with people to contact: For more information and people who can assist you, see Copyright license reminder.
 * 5) The license guide which is currently linked is too terse, we need a page with a sort of FAQ: OMFGBBQ, I got this message, what do I do now?
 * 6) Instructions on how to get the image deleted, including delete-tagging it or leaving a message for the admins on the license reminder page (there could be section: Users, tell us what images you want deleted) or some such
 * 7) In short, keep the message short and conspicuous (box like copyvio notice?), put everything else in the Reminder page that should be conspicuously linked.
 * 8) The proposed way is to place text on the user's talk page. This can be spoofed, it will be dead weight after a time, and there is no way to track for the other editors who got messaged. I propose to put a template on the page, it'd look like   . That way we can change the message at any time, and anyone can see by the transclusions of the template which users have it.
 * 9) It should be placed at the top of the user page (or talk page?).
 * 10) User pages or User Talk pages may not exist, or they may have been redirected. Does the bot provide a log of users that need to be tracked down manually?
 * 11) Can IPs upload images? If so, posting on their talk page may be rather pointless.
 * 12) Add to the bot task that requests for deletion for images should be cleared before the bot is run to avoid annoying users who have already decided that they want to get rid of the image.
 * Where it says would be the signature of the bot. So it includes the date and such. I don't see a reason why people would care if other people got the message. I would rather keep the message more like a normal talk page notice that a normal person might put rather than have some template. So I'd be against having it be a big flashy template on the top of their page. Its no different from any other message. Leaving messages on IP's talk pages is plenty useful. IPs are notified of new messages on their talk page the same way that a regular user is. The main purpose of this is simply to say, "hey, you forgot licensing info on your image; take care of that" not to post a huge guide on how to delete/tag/use images. If the licensing guide itself is lacking, changes to it should be proposed there. It appears to be a pretty good guide to me. It explains how and why we need tags, when to use the different tags, and how to use them. &mdash;♥ Jedi ♥ Rogue ♥ 21:48, 5 June 2008 (UTC)
 * Oh and as for non-existent or redirected userpages. It might have a problem with redirects (not sure; has to do with the framework) and it might (though i doubt it) have issues with non-existence pages. That was a very good thing to test which I didn't consider. Thank you. 22:13, 5 June 2008 (UTC)
 * You shouldn't have any problems with editing redirect pages because the redirect counts as "content", although the notice would obviously get hidden by the redirect. &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 22:19, 5 June 2008 (UTC)
 * Thats the problem. If the talk page has a redirect, it probably goes to the correct talk page for that user (such as if they changed names or moved). This probably won't come up often because most users don't upload images from an account they don't use so we probably won't have to deal with it. Anyway, the issue is, the notice shouldn't go on that page, it should go on the page it redirects to. The framework probably doesn't know to follow the redirect(have to see if there is some function for it). As for redirects on images taht it checks that won't be an issuefor the reason Ishmael pointed out. 69.122.146.84 22:26, 5 June 2008 (UTC)
 * Okay, we work fine on blank userpages but not so well on userpages with a redirect. I will look into seeing if I can write it to follow the redirect but I'm not sure its really nessecary to bother.If the person wants to be uploading stuff from an account with a talk page that has a redirect, they likely will log in as that acount at some point and see teh new messages notice. In that case, they might be confused because they go to check their messaegs and are redirected, but the people who have such redirects would probably realize this and bounce back to the page with teh redirect and examine it. 69.122.146.84 23:16, 5 June 2008 (UTC)

Okay, here's another issue. Its starting to look like bot posts aren't triggering the new messages notice. Which doesn't sound right because I could have sworn they do. Is it just me and the notice isn't popping up for me? Or is this true for all bot posts? Because that kinda puts a damper on the whole thing. &mdash;♥ Jedi ♥ Rogue ♥ 23:21, 5 June 2008 (UTC)
 * I posted on my talk page with my bot, and it didn't trigger my new messages, either. That sucks indeed.  I wonder if that's a MediaWiki setting that we could get Wikia staff to change for us.  &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 23:28, 5 June 2008 (UTC)
 * Its weird. It looks like it may be showing up with some delay. Because I've been logging in and out and posting on my IP's talk page as my bot and me and I just tried it, got a notice, and clickng the last change button pointed me to an old edit where my bot had posted one of the first tests on that page. I don't know if its lagged the new messages thing, or if I just got mixed up with my testing between me and the bots edits. However, I can find nothing on wikipedia saying that wiki bots don't trigger the new message notice. Its odd because, they use bots leaving notices on people's talk pages all the time there and it would be silly if it didn't trigger. Perhaps it is a setting with MediaWiki. &mdash;♥ Jedi ♥ Rogue ♥ 23:33, 5 June 2008 (UTC)
 * According to this the only special privileges that the bot has is to hide its edits from recent changes. I can't find anything about a setting having to do with bots not triggering new messages notice. &mdash;♥ Jedi ♥ Rogue ♥ 23:45, 5 June 2008 (UTC)

Notice!
The bot is currently down. I am getting a parsing error on what appears to be the Special:Newimages page for some reason. It can no longer build by DOM because its suddenly not valid XHTML because it has a tag instead of a  tag. Why this would have suddenly changed, I have no idea since its throwing the error at a part of the code that was previously tried and true. So if anyone knows of something related which might have changed, I'd love to know. &mdash;♥ Jedi ♥ Rogue ♥ 22:48, 5 June 2008 (UTC)
 * I don't see any &lt;br> tags in the source for that page, and it validates just fine. Might be something specific to your bot account?  Can you post the source code that the bot is seeing?  &mdash;Dr Ishmael [[Image:Diablo_the_chicken.gif]] 22:59, 5 June 2008 (UTC)
 * I added a catch to the exception and it seemed to be giving me the wrong next page. Something about giving me #searchIndex or something instead of the url for the next page. I ran it again with some debugging stuff uncommented (only printlns) and it seems to work fine now. I think it was a weird fluke. Perhaps it had to do with a particular ad that showed up on the page that time. JediBot 23:03, 5 June 2008 (UTC)

Pending confirmation
Pending confirmation from a second sysop, I intend to start this bot one week after I post the final version of the code. This bot cannot be confirmed until after that point because I want someone else to review the code. I think that most of the issues with the bot have been discussed and it merely needs some coding kinks worked out. &mdash;♥ Jedi ♥ Rogue ♥ 19:40, 6 June 2008 (UTC)